Reuse StringFrom for modelType extraction in C# - #684
Merged
Merged
Conversation
The interface and named-union deserialization methods duplicated the JsonValue-cast-and-TryGetValue logic for extracting the modelType string inline, instead of reusing the existing ``DeserializeImplementation.StringFrom`` already used for this exact purpose elsewhere. This reduces the generated code size at every interface and named-union ``*From`` method.
Coverage Report for CI Build 34485469675Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 85.242%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interface and named-union deserialization methods duplicated the JsonValue-cast-and-TryGetValue logic for extracting the modelType string inline, instead of reusing the existing
DeserializeImplementation.StringFromalready used for this exact purpose elsewhere. This reduces the generated code size at every interface and named-union*Frommethod.