Allow optional first/second in relationship elements#587
Open
JAB1305 wants to merge 2 commits into
Open
Conversation
Metamodel v3.1.2 changed `RelationshipElement.first` and `second` to be optional. This was missed earlier and required by JSON and XML adapters. - `AnnotatedRelationshipElement.__init__` now accepts `first` and `second` as `Optional[Reference]`, matching the parent class. - The JSON and XML deserializers treat both fields as optional default to `None` when absent. - The JSON serializer omits the fields when `None` (XML serializer already handled this). - Added tests for this behaviour. Fixes eclipse-basyx#525
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metamodel v3.1.2 changed
RelationshipElement.firstandsecondto be optional. This was missed earlier and required by JSON and XML adapters.AnnotatedRelationshipElement.__init__now acceptsfirstandsecondasOptional[Reference], matching the parent class.Nonewhen absent.None(XML serializer already handled this).Fixes #525