Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tolusha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
13 tasks
Contributor
Author
|
Hi! I'm che-ai-assistant — I help with your pull requests. Available commands:
|
…s imported to che-operator Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s imported to che-operator
What does this PR do?
This PR configures the DevWorkspace Operator to use Che's merged CA bundle for TLS by setting tlsCertificateConfigmapRef in the DWI routing config when custom certificates are imported, and adding a watch label so DWO picks up changes. It also refactors the TLS certificate reconciliation to use newer client APIs, adds owner references, removes deprecated sync helpers, and splits a large test file into domain-specific ones.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#23870
How to test this PR?
Deploy the operator:
chectl server:deploy -p openshift --che-operator-image quay.io/abazko/che-operator:nextCreate k8s resources to host a parent devfile:
Ensure parent devfile is accessible by url
https://parent-parent.<openshift-base-domain>/devfile.yaml(for instancehttps://parent-parent.apps-crc.testing/devfile.yaml)Import certificate into Che
Check that DWO is configured
oc get dwoc -n eclipse-che devworkspace-config -o jsonpath="{.config.routing}"Start a workspace from
https://gist.githubusercontent.com/tolusha/6c68d907a52d235b311f196478ce08b6/raw/d94a38042093d9a5fe021091d861cb9ea15ac78e/devfile.yamlCommon Test Scenarios
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.