Skip to content

statement: renderer-owned dialect degradation and demo test suite#32

Merged
stbischof merged 1 commit into
eclipse-daanse:mainfrom
stbischof:wip/sqlquery-querymap
Jul 9, 2026
Merged

statement: renderer-owned dialect degradation and demo test suite#32
stbischof merged 1 commit into
eclipse-daanse:mainfrom
stbischof:wip/sqlquery-querymap

Conversation

@stbischof

Copy link
Copy Markdown
Contributor

Consolidates the dialect-aware SQL rendering work:

  • Renderer decides null-collation ordering for UNION ORDER BY ordinals (requiresUnionOrderByOrdinal) instead of the model.
  • Renderer completes GROUP BY for restrictive dialects, with a per-projection GROUP-BY-completion exemption marker.
  • Renderer degrades count(distinct) to a dummyname subquery (P2b) and renders InTuple degradation parent-first without its own outer parenthesis.
  • Deletes the statement.compare seam (StatementEquivalence, SqlTextNormalizer) now that the renderer owns SQL-shape decisions.
  • Follows jdbc dependency moves: SQL-shape enums to jdbc.db.api.sql and the type model to jdbc.db.api.type.
  • Adds the statement.demo module with a broad demo/test suite covering aggregates, CTEs, joins, comments, parameters and more, plus renderer hardening tests.

Consolidates the dialect-aware SQL rendering work:

- Renderer decides null-collation ordering for UNION ORDER BY ordinals
  (requiresUnionOrderByOrdinal) instead of the model.
- Renderer completes GROUP BY for restrictive dialects, with a
  per-projection GROUP-BY-completion exemption marker.
- Renderer degrades count(distinct) to a dummyname subquery (P2b) and
  renders InTuple degradation parent-first without its own outer
  parenthesis.
- Deletes the statement.compare seam (StatementEquivalence,
  SqlTextNormalizer) now that the renderer owns SQL-shape decisions.
- Follows jdbc dependency moves: SQL-shape enums to jdbc.db.api.sql and
  the type model to jdbc.db.api.type.
- Adds the statement.demo module with a broad demo/test suite covering
  aggregates, CTEs, joins, comments, parameters and more, plus renderer
  hardening tests.

Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
@stbischof stbischof force-pushed the wip/sqlquery-querymap branch from 97ddb67 to db21b19 Compare July 9, 2026 11:34
@stbischof stbischof merged commit f2f2bcd into eclipse-daanse:main Jul 9, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant