Skip to content

make mandb handling runner-safe and refine apt install benchmarks#7 - #8

Merged
AlexanderLanin merged 6 commits into
eclipse-score:mainfrom
bgsw-contrib:feature/apt-install-time-measurement-test
Aug 10, 2026
Merged

make mandb handling runner-safe and refine apt install benchmarks#7#8
AlexanderLanin merged 6 commits into
eclipse-score:mainfrom
bgsw-contrib:feature/apt-install-time-measurement-test

Conversation

@Vinodha-kumar

@Vinodha-kumar Vinodha-kumar commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

The apt-install action and benchmark workflow to handle GitHub runner changes around man-db and to make benchmark comparisons fairer.

Relates to #7

This comment was marked as outdated.

Updated benchmark workflow to include apt_update and modified CSV processing for statistics.

Signed-off-by: Vinodha kumar mv  <vinodha.kumarmv@in.bosch.com>
…urement

Enhance benchmark.yml with apt_update and CSV fixes

This comment was marked as outdated.

Added step to disable mandb updates for baseline parity.

Signed-off-by: Vinodha kumar mv  <vinodha.kumarmv@in.bosch.com>
…urement

Disable mandb updates in benchmark workflow

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (3)

.github/workflows/benchmark.yml:98

  • This setting does not apply to the cache: true path: action.yml only forwards packages, and cache-apt-pkgs-action v1.4.3 performs a normal apt-fast install without --no-install-recommends. The plain and no-cache jobs suppress recommendations, so the three benchmarks can install different package sets and are not like-for-like. Align the install semantics across all jobs or make the cached path honor this input.
          cache: true
          apt_update: true
          recommends: false
          mandb: false

action.yml:47

  • command -v follows the caller-controlled PATH, but the package's trigger invokes the system mandb executable. If an earlier shim/custom installation exists, this overwrites that file while leaving /usr/bin/mandb active, so mandb: false no longer disables the trigger. Check and replace the package-owned path directly.
        if command -v mandb >/dev/null 2>&1; then
          MANDB_PATH="$(command -v mandb)"
          echo "mandb found at ${MANDB_PATH}; stubbing to /bin/true"
          sudo ln -sf /bin/true "${MANDB_PATH}"

.github/workflows/benchmark.yml:34

  • The baseline should stub the package-owned executable rather than whichever mandb happens to appear first in PATH; dpkg's man-db trigger targets the system executable, so a custom PATH entry would leave updates enabled and invalidate baseline parity.

This issue also appears on line 95 of the same file.

          if command -v mandb >/dev/null 2>&1; then
            sudo ln -sf /bin/true "$(command -v mandb)"

@AlexanderLanin
AlexanderLanin merged commit d545215 into eclipse-score:main Aug 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants