make mandb handling runner-safe and refine apt install benchmarks#7 - #8
Merged
AlexanderLanin merged 6 commits intoAug 10, 2026
Conversation
…urement make mandb handling runner-safe and refine apt install benchmarks#7
Vinodha-kumar
requested review from
AlexanderLanin,
MaximilianSoerenPollak and
dcalavrezo-qorix
as code owners
August 6, 2026 17:24
Updated benchmark workflow to include apt_update and modified CSV processing for statistics. Signed-off-by: Vinodha kumar mv <vinodha.kumarmv@in.bosch.com>
…urement Enhance benchmark.yml with apt_update and CSV fixes
Added step to disable mandb updates for baseline parity. Signed-off-by: Vinodha kumar mv <vinodha.kumarmv@in.bosch.com>
…urement Disable mandb updates in benchmark workflow
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (3)
.github/workflows/benchmark.yml:98
- This setting does not apply to the
cache: truepath:action.ymlonly forwardspackages, and cache-apt-pkgs-action v1.4.3 performs a normalapt-fast installwithout--no-install-recommends. The plain and no-cache jobs suppress recommendations, so the three benchmarks can install different package sets and are not like-for-like. Align the install semantics across all jobs or make the cached path honor this input.
cache: true
apt_update: true
recommends: false
mandb: false
action.yml:47
command -vfollows the caller-controlledPATH, but the package's trigger invokes the systemmandbexecutable. If an earlier shim/custom installation exists, this overwrites that file while leaving/usr/bin/mandbactive, somandb: falseno longer disables the trigger. Check and replace the package-owned path directly.
if command -v mandb >/dev/null 2>&1; then
MANDB_PATH="$(command -v mandb)"
echo "mandb found at ${MANDB_PATH}; stubbing to /bin/true"
sudo ln -sf /bin/true "${MANDB_PATH}"
.github/workflows/benchmark.yml:34
- The baseline should stub the package-owned executable rather than whichever
mandbhappens to appear first inPATH; dpkg's man-db trigger targets the system executable, so a custom PATH entry would leave updates enabled and invalidate baseline parity.
This issue also appears on line 95 of the same file.
if command -v mandb >/dev/null 2>&1; then
sudo ln -sf /bin/true "$(command -v mandb)"
AlexanderLanin
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The apt-install action and benchmark workflow to handle GitHub runner changes around man-db and to make benchmark comparisons fairer.
Relates to #7