Add config for GCC 15.3.0 - #117
Merged
Merged
Conversation
nradakovic
force-pushed
the
nira_add_gcc15
branch
from
August 11, 2026 15:59
7ea8012 to
cb4f3b4
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Bazel module/toolchain configuration so GCC 15.3.0 packages can be fetched via the repo’s version matrix and used in the test workspace, alongside existing GCC 12.2.0 configurations.
Changes:
- Register GCC 15.3.0 tarball packages in
packages/version_matrix.bzl(and generate corresponding externalgcc.BUILDpackage descriptors). - Add new test-workspace toolchain definitions and
.bazelrcconfigs for selecting GCC 15.3.0. - Bump
score_bazel_platforms(and related lockfiles) to1.0.0, and bumpscore_rules_imagefsin the test module.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/MODULE.bazel.lock | Updates Bazel module lock, including new GCC 15.3 package/toolchain repos. |
| tests/MODULE.bazel | Adds GCC 15.3 toolchain(s) to the test module and updates module deps. |
| tests/.bazelrc | Adds Bazel configs to select GCC 15.3 toolchains in tests. |
| packages/version_matrix.bzl | Registers GCC 15.3.0 in the central package/version matrix. |
| packages/linux/x86_64/gcc/15.3.0/gcc.BUILD | New external package BUILD for x86_64 GCC 15.3.0 tarball layout. |
| packages/linux/x86_64/gcc/15.3.0/BUILD | Exposes gcc.BUILD for x86_64 GCC 15.3.0 package. |
| packages/linux/aarch64/gcc/15.3.0/gcc.BUILD | New external package BUILD for aarch64 GCC 15.3.0 tarball layout. |
| packages/linux/aarch64/gcc/15.3.0/BUILD | Exposes gcc.BUILD for aarch64 GCC 15.3.0 package. |
| MODULE.bazel.lock | Updates root module lockfile for score_bazel_platforms bump. |
| MODULE.bazel | Bumps score_bazel_platforms to 1.0.0. |
Suppressed comments (1)
tests/MODULE.bazel:199
- If aarch64 GCC 15.3.0 remains out of scope (per issue #100), it should not be registered in use_repo for the test module.
"my_toolchain",
"score_aarch64_gcc_toolchain",
"score_aarch64_gcc_toolchain_15",
"score_autosd_10_toolchain",
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+24
to
+29
| "aarch64-linux-gcc_15.3.0": { | ||
| "build_file": "@score_bazel_cpp_toolchains//packages/linux/aarch64/gcc/15.3.0:gcc.BUILD", | ||
| "sha256": "ff9fe6caed22f15a1dd87a93bff5cfa1536b5dddcff3364827f97ebc01a494a1", | ||
| "strip_prefix": "aarch64-unknown-linux-gnu", | ||
| "url": "https://github.com/eclipse-score/toolchains_gcc_packages/releases/download/v0.0.5/aarch64-unknown-linux-gnu_gcc15.tar.gz", | ||
| }, |
Comment on lines
+118
to
+127
| # ******************************************************************************* | ||
| # Setting default GCC (CPU:aarch64|OS:Linux|V:15.3.0|ES:posix) | ||
| # ******************************************************************************* | ||
| gcc.toolchain( | ||
| name = "score_aarch64_gcc_toolchain_15", | ||
| target_cpu = "aarch64", | ||
| target_os = "linux", | ||
| use_default_package = True, | ||
| version = "15.3.0", | ||
| ) |
Comment on lines
+87
to
+93
| # ------------------------------------------------------------------------------- | ||
| # Toolchain configuration for aarch64-linux (target) | ||
| # ------------------------------------------------------------------------------- | ||
| build:aarch64-linux-gcc15 --config=x86_64-linux | ||
| build:aarch64-linux-gcc15 --platforms=@score_bazel_platforms//:aarch64-linux-gcc_15.3.0-posix | ||
| build:aarch64-linux-gcc15 --extra_toolchains=@score_aarch64_gcc_toolchain_15//:aarch64-linux-gcc_15.3.0 | ||
|
|
Comment on lines
+95
to
+100
| "x86_64-linux-gcc_15.3.0": { | ||
| "build_file": "@score_bazel_cpp_toolchains//packages/linux/x86_64/gcc/15.3.0:gcc.BUILD", | ||
| "sha256": "c65e21725d4d9993bab0b4ef2aed7065a4bf1b0f232a068d778eb670f80daa60", | ||
| "strip_prefix": "x86_64-unknown-linux-gnu", | ||
| "url": "https://github.com/eclipse-score/toolchains_gcc_packages/releases/download/v0.0.5/x86_64-unknown-linux-gnu_gcc15.tar.gz", | ||
| }, |
nradakovic
marked this pull request as draft
August 11, 2026 16:01
The new configuration for gcc 15.3.0 is added to be available for developer testing. resolves: #100
nradakovic
force-pushed
the
nira_add_gcc15
branch
from
August 11, 2026 16:07
cb4f3b4 to
1154a1b
Compare
Add permissions for workflows.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 16 changed files in this pull request and generated no new comments.
Suppressed comments (4)
.github/workflows/qnx.yml:16
- The workflow-level
permissionsnow grantsactions: write, but theqnx-buildjob has an explicitpermissions:block that omitsactions. Job-level permissions override workflow-level permissions, soqnx-buildwill not actually getactions: write(which may break cache uploads whencache-saveis enabled on push).
permissions:
contents: read
actions: write
.github/workflows/aarch64-linux.yml:65
- The new aarch64 GCC15 build step doesn’t enforce lockfile immutability. Other Linux workflows run with
--lockfile_mode=errorto ensure CI doesn’t silently update lockfiles.
- name: Bazel Build (basic)
run: |
bazel build --config=aarch64-linux-gcc15 -- //:language_and_standards_tests //:feature_verification_tests
.github/workflows/aarch64-linux.yml:68
- The new aarch64 GCC15 guardrail test step should also use
--lockfile_mode=errorfor consistency with other CI jobs and to prevent lockfile drift.
- name: Guardrail (no legacy features)
run: |
bazel test --config=aarch64-linux-gcc15 -- //:guardrail_tests
packages/version_matrix.bzl:28
- The PR description says it "resolves: #100", but issue #100’s acceptance criteria includes documentation updates and ensuring the new toolchain is exercised by the existing feature/language test suites. This PR adds the version matrix entries and CI wiring, but does not update any documentation; either add the required docs updates or avoid marking the issue as resolved yet.
"aarch64-linux-gcc_15.3.0": {
"build_file": "@score_bazel_cpp_toolchains//packages/linux/aarch64/gcc/15.3.0:gcc.BUILD",
"sha256": "ff9fe6caed22f15a1dd87a93bff5cfa1536b5dddcff3364827f97ebc01a494a1",
"strip_prefix": "aarch64-unknown-linux-gnu",
"url": "https://github.com/eclipse-score/toolchains_gcc_packages/releases/download/v0.0.5/aarch64-unknown-linux-gnu_gcc15.tar.gz",
Add in documentation info for gcc15.
AlexanderLanin
marked this pull request as ready for review
August 13, 2026 13:30
AlexanderLanin
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new configuration for gcc 15.3.0 is added to be available for developer testing.
resolves: #100