fix(qnx): reorder user_link_flags after libraries_to_link - #128
Merged
Conversation
Fixes undefined reference errors (e.g. __gcov_dump) caused by user linkopts appearing before the objects/libraries that need them on the QNX link command line. Matches the Linux template's ordering.
nradakovic
added
template
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the QNX C++ toolchain config template to ensure user-provided link flags (linkopts) are applied after Bazel’s libraries_to_link arguments, preventing link-order–dependent undefined reference errors (e.g., __gcov_dump) and aligning QNX behavior with the Linux template.
Changes:
- Reordered
user_link_flags_featureto come afterlibraries_to_link_featurein the QNX toolchainfeatureslist.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AlexanderLanin
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes undefined reference errors (e.g. __gcov_dump) caused by user linkopts appearing before the objects/libraries that need them on the QNX link command line.
Matches the Linux template's ordering.