Fix noexcept MISRA findings - #900
Draft
castler wants to merge 4 commits into
Draft
Conversation
castler
requested review from
LittleHuba,
bemerybmw,
crimson11,
hoe-jo and
limdor
as code owners
August 11, 2026 12:56
castler
marked this pull request as draft
August 11, 2026 13:08
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| std::weak_ptr<FindServiceHandler<HandleType>> handler_weak_ptr, | ||
| const EnrichedInstanceIdentifier& enriched_instance_identifier) noexcept -> Result<void> | ||
| auto ServiceDiscovery::BindingSpecificStartFindService(FindServiceHandle search_handle, | ||
| std::weak_ptr<FindServiceHandler<HandleType>> handler_weak_ptr, |
Remove noexcept from APIs and helpers that can propagate exceptions, including tracing, service discovery, proxy, LoLa binding, and shared-memory paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| const UserPermissions& permissions, | ||
| AccessControlListFactory acl_factory, | ||
| std::shared_ptr<score::memory::shared::TypedMemory> typed_memory_ptr) noexcept | ||
| std::shared_ptr<score::memory::shared::TypedMemory> typed_memory_ptr) |
| const UserPermissions& permissions, | ||
| AccessControlListFactory acl_factory, | ||
| std::shared_ptr<score::memory::shared::TypedMemory> typed_memory_ptr) noexcept | ||
| std::shared_ptr<score::memory::shared::TypedMemory> typed_memory_ptr) |
| const UserPermissions& permissions, | ||
| AccessControlListFactory acl_factory, | ||
| std::shared_ptr<score::memory::shared::TypedMemory> typed_memory_ptr) noexcept | ||
| std::shared_ptr<score::memory::shared::TypedMemory> typed_memory_ptr) |
| const UserPermissions& permissions, | ||
| score::os::IAccessControlList* acl_control_list, | ||
| std::shared_ptr<score::memory::shared::TypedMemory> typed_memory_ptr) noexcept | ||
| std::shared_ptr<score::memory::shared::TypedMemory> typed_memory_ptr) |
Keep declarations and definitions consistent after removing noexcept from exception-capable creation paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| SharedMemoryResource::InitializeCallback initialize_callback, | ||
| const UserPermissions& permissions, | ||
| score::os::IAccessControlList* acl_control_list, | ||
| std::shared_ptr<score::memory::shared::TypedMemory> typed_memory_ptr) |
Restore terminating allocation behavior, align the LoLa skeleton destructor contract, and keep shared-memory helpers clang-formatted. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Declare the LoLa generic skeleton event destructor noexcept so Clang sanitizer builds match the non-throwing base destructor. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove noexcept from APIs and helpers that can propagate exceptions, including tracing, service discovery, proxy, LoLa binding, and shared-memory paths.