feat(deps): add score_config_management to reference integration - #299
feat(deps): add score_config_management to reference integration#299Chahult wants to merge 4 commits into
Conversation
bd6eea0 to
78bd1c3
Compare
|
Hi @pawelrutkaq @PiotrKorkus @nradakovic @antonkri @AlexanderLanin , could someone please unlock this workflow and review our changes? Thanks! |
78bd1c3 to
bd8ae34
Compare
|
Updated the baselibs to the latest version as builds are breaking. |
Please bump to the version pulled in by communication. That gives you a good chance to have a successful build. |
de696a5 to
3e1e4d9
Compare
f47156d to
dc4ec5d
Compare
d4e848d to
c017095
Compare
Pin score_config_management to 49f26b74 and add a patch (sourced from config_management PR#37) fixing the ProxyFuture API migration and removing SOCAL/component_tests targets not present in the OSS build.
c017095 to
a9899c5
Compare
|
The created documentation from the pull request is available at: docu-html |
|
Hi @pawelrutkaq @PiotrKorkus , could you please review and approve these changes? The aim of this PR is to add |
| "repo": "https://github.com/eclipse-score/config_management.git", | ||
| "hash": "b22ca9bd222b99985be4339187c639d6862051a0", | ||
| "bazel_patches": [ | ||
| "patches/config_management/001-fix-communication-api-and-remove-targets.patch" |
There was a problem hiding this comment.
Since this looks like an arbitrary patch, someone from com shall ack it.
There was a problem hiding this comment.
The current name 001-fix-communication-api-and-remove-targets.patch is misleading — the patch doesn't fix the communication library, it adapts config_management to the new ProxyFuture API and removes internal/ARA-specific targets. Let me rename it
There was a problem hiding this comment.
Please do not integrate new module with patches, please fix it upstream
There was a problem hiding this comment.
The OptionalProxyData → ProxyFuture part of the patch is a temporary mismatch caused by an in-progress mw::com migration: the internal main repo still uses the old OptionalProxyData API, while the OSS communication repo has already migrated to ProxyFuture. Once that migration completes and syncs upstream, config_management's main repo will use ProxyFuture too, and this part of the patch will no longer be needed — no upstream fix is possible for this piece yet.
| "//score/config_management/config_daemon/code/services/details/mw_com:unit_test", | ||
| "//score/config_management/config_provider/code/config_provider/factory:unit_tests_mw_com", | ||
| "//score/config_management/config_provider/code/proxies/details:unit_test_mw", | ||
| "//score/config_management/dependability/..." |
There was a problem hiding this comment.
why we need those exclusions ?
There was a problem hiding this comment.
1.mw_com tests: require a running LoLa/SOME/IP runtime — the tests themselves are tagged "exclusive" because "Sandboxing is not properly working with LoLa message passing 2.0". Same reason score_communication excludes //score/mw/com/impl:unit_test_runtime_single_exec and //score/mw/com/impl:runtime_test.
2.dependability/...: these are component/dependable_element safety-metadata targets from score_tooling, not executable tests. Including //... without filtering them would cause build failures.
pawelrutkaq
left a comment
pawelrutkaq
left a comment
There was a problem hiding this comment.
If comm has already this change in, I would suggest to update com as well here.
af816ea to
d717f5d
Compare
d717f5d to
cf3520b
Compare
4 participants
Added score_config_management module (commit ) to known_good.json under target_sw with code_root_path //score/config_management/...
Regenerate bazel_common/score_modules_target_sw.MODULE.bazel