Repository navigation
fix(boot): only redraw what changed in the graphical menu - #121
Merged
Merged
Conversation
Each frame redrew the whole screen and blitted the entire framebuffer. The static background and panel are now cached, and only the changed regions are blitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drawing a frame of the graphical menu was slow because every tick redrew the whole screen and blitted the entire framebuffer to the display.
The background, title, panel and footer line never change, so they are now drawn once into a cached buffer that each frame starts from. After a frame is drawn it is compared with the one last shown, and only the rows and columns that changed are blitted, with separate rectangles for changes far apart such as the logo and the status line. The first frame still fills the display. The logo scaling also no longer recalculates the source row for every pixel.
This keeps two more full-size buffers per display. I checked it with clippy and rustfmt on both targets but haven't timed it in QEMU yet.