refactor: remove noqa comment from the __init__ file - #647
Conversation
|
Nice cleanup. Removing noqa can affect lint behavior; include before/after lint result in PR description? |
@arturict Updated. |
JackSpiece
left a comment
There was a problem hiding this comment.
Checked 32a2dba in separate environments with and without docxcompose. In both cases, from docxtpl import * exports exactly the names declared by docxtpl.__all__. The environment with docxcompose includes Subdoc; the environment without it imports cleanly and excludes only Subdoc.
The exact flake8 command and git diff --check pass locally, and the upstream test and codestyle matrix is green from Python 3.7 through 3.14. This preserves the optional dependency behavior while removing the blanket noqa. Looks good.
Description
__all__todocxtpl/__init__.pyso that the# noqacomment is no longer needed.from .richtext import ....Validation results:
flake8check:docxcomposeis not installed: