Expand self-closing tcPr before inserting gridSpan and shd - #656
Open
zxyasfas wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #559.
Pandoc (and some other producers) collapse empty cell properties to a self-closing
<w:tcPr/>. The insertion regex incolspan()andcellbg()matches that form too ([^>]*eats the/), so<w:gridSpan>/<w:shd>end up as a sibling after the closed element instead of inside it. That position is schema-invalid and Word silently drops it, which matches the silent breakage reported in the issue.The fix expands a self-closing
<w:tcPr/>(attributes preserved) into an open/close pair before the existing insertion runs. Templates that already have an expanded<w:tcPr>go through exactly the same path as before.Added tests/cellbg_selfclosing.py covering cellbg and colspan against a self-closing tcPr, one with attributes, and the already-expanded form. It asserts on patch_xml output directly so it needs no template file. Ran the rest of the tests dir locally, all green.