Draft
Fix RSpec expectation ordering error in metrics_spec callback test#1651
Conversation
…r possible invocation
Copilot
AI
changed the title
[WIP] Fix failing CI job in metrics_spec.rb
Fix RSpec expectation ordering error in metrics_spec callback test
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On certain CI matrix entries,
collect_and_sendinvokes the callback during the first (probe) call, causing RSpec to reject a subsequentreceive(:call)expectation on an already-invoked proc.Change
spec/elastic_apm/metrics_spec.rb: Replace the post-invocation RSpec message expectation with a plain call recorder (array spy). The callback appends each metricset tocalls; after the secondcollect_and_send, the test assertscallsincludes aMetricset. Thenext unlessskip path for unsupported environments is preserved.