Fix stale changelog registry - #3911
Open
lcawl wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR must be merged after #3801 since it uses that PR as its base.
Context
changelog bundleCDN sourcing today does this:After #3760, nothing writes
changelog/{org}/{repo}/{branch}/registry.json. The scrubber only reconcilesbundle/{product}/registry.json. Uploaded YAML is on S3/CDN; the pool index is frozen.This means that changelogs that I've uploaded recently to the CDN are not findable by the
docs-builder changelog bundlecommand because they're not reflected in the registry.Implementation details
What changed in docs-builder
changelog/{org}/{repo}/{branch}/registry.jsonfrom the public YAML listing.targetis always null for the pool. Client JSON is not copied.--prs(local and CDN) uses the same join as git-ref: leading filename digits or YAMLprs:. Emptyprs:still matches12345.yaml.--files/ a path list GETs those basenames only (noregistry.json). A missing name still fails the run.--alland product-only filters error and point at--force-local. Local--allis unchanged. Git-ref infer is unchanged.After merge, Kibana’s stale listing only heals once the scrubber Lambda is deployed. CLI-only is not enough. A
--skip-etag-checkupload (or the next YAML event) after that deploy rewriteschangelog/elastic/kibana/main/registry.json.Behavior to be aware of: a CDN monthly/product-only bundle (no PR/file list), like the cloud
products:profile with only a date argument, now errors until phase 3. Use--force-localfor those runs (this should be fine since we've now removed those profiles).Kibana's
serverless-release … prs.txtis--prsand is the path this fixes.