Fail CMake configure if 3rd-party git clone fails (#3164) (#8.19) - #3167
Closed
edsavage wants to merge 2 commits into
Closed
Fail CMake configure if 3rd-party git clone fails (#3164) (#8.19)#3167edsavage wants to merge 2 commits into
edsavage wants to merge 2 commits into
Conversation
Previously, execute_process() silently ignored a non-zero exit from the git clone command. If the GitLab server is unavailable or overloaded, CMake would continue configuring with no Eigen headers present, leading to a cryptic compiler error hundreds of lines later instead of a clear configure-time failure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Same hardening as pull-eigen.cmake: report a clear configure-time error if the git clone fails rather than silently continuing and producing a cryptic compiler error later. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Closing in favour of auto-backport from #3164 after merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3164 to 8.19.
Adds
RESULT_VARIABLEchecking to bothpull-eigen.cmakeandpull-valijson.cmakeso a transient network failure during CMake configure produces a clear error message rather than a cryptic compiler error later.🤖 Generated with Claude Code