DDF and clustering updates - #286
Open
maclariz wants to merge 2 commits into
Open
Conversation
Some corrections to the new DDF and clustering routines. "noise" was renamed to "unclustered". An additional function added to put grain labels into a vector. The dbscan was rewritten with help from Claude to eliminate some inefficiencies that made it slow on CPU. An updated ipynb will be sent to accompany this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the work from Sunday was checked. The clustering implementation of dbscan was speeded up with help from Claude to remove redundant scans. "noise" was renamed to "unclustered". A new function was made to add L2 grain labels to a vector, which then makes plotting of diffraction patterns from L2 clusters easy using the existing scatter plot function. This was altered slightly to allow plotting of individual components. I also added docstrings to some functions.
To do: