Decode inet, pg_lsn, and ltree types on CockroachDB - #792
Merged
Conversation
CockroachDB generates pg_type's send/output proc names as the type name plus "send"/"out" and only inserts an underscore for types on a hardcoded allow-list (typeBuiltinsHaveUnderscore). Like void (fixed in reports inetsend / pg_lsnsend / ltreesend where Postgres reports inet_send / pg_lsn_send / ltree_send. The built-in extensions never bind and selecting those types raises "type ... can not be handled". Match CRDB's proc spelling in addition to Postgres'. The binary wire formats are identical on both engines (inet uses the same family/mask/is_cidr/addr header, pg_lsn is an int64, ltree is the version-1-byte-plus-text format), so only the matching changes and the Postgres path is unaffected.
milmazz
force-pushed
the
crdb-typsend-compat
branch
from
August 6, 2026 17:47
f80a409 to
cc7f73b
Compare
milmazz
marked this pull request as ready for review
August 6, 2026 17:47
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a similar issue as in #791, but this time for: inet, pg_lsn, and ltree types on CockroachDB