Skip to content

Fix notifications lost during idle ping - #795

Merged
josevalim merged 1 commit into
elixir-ecto:masterfrom
lukaszsamson:ls-fix-lost-notification-ping
Sep 6, 2026
Merged

Fix notifications lost during idle ping#795
josevalim merged 1 commit into
elixir-ecto:masterfrom
lukaszsamson:ls-fix-lost-notification-ping

Conversation

@lukaszsamson

Copy link
Copy Markdown
Contributor

This PR adds public Protocol.ping/2 and passes notify callback option to Protocol.new_status/2 when handling idle :timeout event.

Note: this new Protocol.ping/2 is not a callback of DbConnection behaviour. Downside is ping/1 called directly still defaults to [] options. Alternatives:

  • extend the DbConnection callback surface
  • keep using ping/1 but instead pass notify as state struct property

I'm happy to make the changes

Fixes #794

@josevalim
josevalim merged commit bd402a5 into elixir-ecto:master Sep 6, 2026
12 of 13 checks passed
@josevalim

Copy link
Copy Markdown
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notifications silently lost during idle connection ping

2 participants