Fix notifications lost during idle ping - #795
Merged
josevalim merged 1 commit intoSep 6, 2026
Merged
Conversation
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds public
Protocol.ping/2and passesnotifycallback option toProtocol.new_status/2when handling idle:timeoutevent.Note: this new
Protocol.ping/2is not a callback ofDbConnectionbehaviour. Downside isping/1called directly still defaults to[]options. Alternatives:DbConnectioncallback surfaceping/1but instead passnotifyas state struct propertyI'm happy to make the changes
Fixes #794