Optimize Keyword.pop/3, pop!/2, and pop_lazy/3#15466
Merged
Merged
Conversation
Eliminate redundant list traversal by calling :lists.keyfind + delete_key directly instead of going through fetch/2 + delete/2. The old code performed 3 traversals when the key was present: 1. :lists.keyfind (inside fetch) 2. :lists.keymember (inside delete — redundant) 3. delete_key (inside delete) The new code performs 2 traversals: 1. :lists.keyfind (find the value) 2. delete_key (remove all matching entries) Benchmark shows ~1.15x speedup on avg (noisy system)
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate redundant list traversal by calling :lists.keyfind + delete_key
directly instead of going through fetch/2 + delete/2.
The old code performed 3 traversals when the key was present:
The new code performs 2 traversals:
Benchmark shows ~1.15x speedup on avg (noisy system)
Because I have read the CONTRIBUTING.md AI section just now:
Assisted-by: Antigravity CLI : Claude Opus 4.6 & Gemini Flash 3.5