Update app.css location to on disk file - #306
Draft
evoactivity wants to merge 1 commit into
Draft
Conversation
evoactivity
changed the title
evoactivity
marked this pull request as draft
August 4, 2026 15:27
11 tasks
Contributor
I don't see why not -- people who use ember-cli-update will see the change in their diff, and nearly (but not exactly) 0 libraries actually use the virtual/vendor files anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing emberjs/rfcs#1148
@mansona @NullVoxPopuli question, do we drop the virtual vendor file at the same time?
This will need a deprecation warning adding to one of the embroider vite plugins detecting usage of
@embroider/virtual/app.css