Repository navigation
Time handed-off commits from request start in n_commit_time - #2
Closed
emelialei88 wants to merge 5 commits into
Closed
emelialei88 wants to merge 5 commits into
emelialei88 wants to merge 5 commits into
Conversation
Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
Owner
Author
|
Folded into bloomberg#6144. |
emelialei88
force-pushed
the
port/async-dist-commit
branch
from
October 1, 2026 20:22
5876642 to
5ae62f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 The "Why" (Intent)
With the seqnum-wait thread,
n_commit_timewas built from two stopwatches: one in toblock that stops at the local commit, and one in the waiter, in ms, that starts at the handoff. The time between them is lost even though acks are already arriving then, so handed-off commits read lower than the same commit waited for inline.🛠️ The "What" (Critical Changes)
seqnum_wait_doneadds the request's time from arrival in µs, read from the logger the request carries to the waiter. This is the same measure the inline wait gives.