Skip to content

fix gap - #6752

Open
wangyenshu wants to merge 6 commits into
emscripten-forge:mainfrom
wangyenshu:gap-fix
Open

fix gap#6752
wangyenshu wants to merge 6 commits into
emscripten-forge:mainfrom
wangyenshu:gap-fix

Conversation

@wangyenshu

Copy link
Copy Markdown
Contributor

Template B: Checklist for updating a package

  • ⚠️ Bump build number if the version remains unchanged
  • Or reset build number to 0 if updating the package to a newer version

PR Formatting

  • PR title follows format: Add [package-name] or Update [package-name] to [version]
  • PR description includes:
    • Version being added/updated
    • Any special build considerations or patches applied

Package Details

  • Package Name: gap
  • Version: 4.16.1

Build Notes

@wangyenshu

Copy link
Copy Markdown
Contributor Author
Screenshot29

I can confirm that gap works after this fix.

@wangyenshu

Copy link
Copy Markdown
Contributor Author

passagemath-gap test says

=================================== FAILURES ===================================
_________________________ test_import_passagemath_gap __________________________
    def test_import_passagemath_gap():
>       import passagemath_gap
E       ModuleNotFoundError: No module named 'passagemath_gap'
test_passagemath_gap.py:5: ModuleNotFoundError
_________________________________ test_libgap __________________________________
    def test_libgap():
>       import passagemath_gap
E       ModuleNotFoundError: No module named 'passagemath_gap'
test_passagemath_gap.py:9: ModuleNotFoundError
=========================== short test summary info ============================

I guess that this is not the gap's issue.

@IsabelParedes

Copy link
Copy Markdown
Member

I guess that this is not the gap's issue.

Something seems to be broken with python tests. Investigating...

make -j8
)

AUX_BUILD=$PWD/extern/emscripten/build

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain for what purpose you need to re-introduce these aux builds of packages that are already in emscripten-forge?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because gap's emscripten build script uses that. I will try to keep the changes minimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants