Skip to content

Added minimum supported version for django-upgrade in pre-commit hook - #10047

Closed
p-r-a-v-i-n wants to merge 1 commit into
encode:mainfrom
p-r-a-v-i-n:add-target-version
Closed

p-r-a-v-i-n wants to merge 1 commit into
encode:mainfrom
p-r-a-v-i-n:add-target-version

Conversation

@p-r-a-v-i-n

Copy link
Copy Markdown
Contributor

Note: Before submitting a code change, please review our contributing guidelines.

Description

Please make my apology if this may create noise.

@p-r-a-v-i-n p-r-a-v-i-n changed the title Added target version for django-upgrade in pre-commit hook Added minimum supported version for django-upgrade in pre-commit hook Sep 15, 2026
Comment thread .pre-commit-config.yaml
rev: 1.32.0
hooks:
- id: django-upgrade
args: [--target-version, "5.2"]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed, django-upgrade gets that from the the pyproject.toml:

dependencies = [ "django>=5.2" ]

No need to duplicate the minimum version in one more place

@browniebroke

Copy link
Copy Markdown
Collaborator

Unless you have some evidence that it doesn't work?

@browniebroke

Copy link
Copy Markdown
Collaborator

Confirmed on my checkout:

 ➜ prek run -a -v django-upgrade
django-upgrade...........................................................Passed
- hook id: django-upgrade
- duration: 0.23s

  Detected Django version from pyproject.toml: 5.2
  Detected Django version from pyproject.toml: 5.2
  Detected Django version from pyproject.toml: 5.2
  Detected Django version from pyproject.toml: 5.2
  Detected Django version from pyproject.toml: 5.2
  Detected Django version from pyproject.toml: 5.2
  Detected Django version from pyproject.toml: 5.2
  Detected Django version from pyproject.toml: 5.2
  Detected Django version from pyproject.toml: 5.2
  Detected Django version from pyproject.toml: 5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants