Added minimum supported version for django-upgrade in pre-commit hook - #10047
Closed
p-r-a-v-i-n wants to merge 1 commit into
Closed
p-r-a-v-i-n wants to merge 1 commit into
p-r-a-v-i-n wants to merge 1 commit into
Conversation
| rev: 1.32.0 | ||
| hooks: | ||
| - id: django-upgrade | ||
| args: [--target-version, "5.2"] |
Collaborator
There was a problem hiding this comment.
This is not needed, django-upgrade gets that from the the pyproject.toml:
django-rest-framework/pyproject.toml
Line 32 in 045af72
No need to duplicate the minimum version in one more place
Collaborator
|
Unless you have some evidence that it doesn't work? |
Collaborator
|
Confirmed on my checkout: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Before submitting a code change, please review our contributing guidelines.
Description
Please make my apology if this may create noise.