Conversation
Signed-off-by: Vlad Stefanescu <vstefanescu@epo.org>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
vladst3f
marked this pull request as ready for review
September 25, 2026 09:41
zirain
approved these changes
Sep 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10113 +/- ##
=======================================
Coverage 81.41% 81.42%
=======================================
Files 266 266
Lines 41300 41304 +4
=======================================
+ Hits 33626 33631 +5
+ Misses 7673 7672 -1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
@zirain the failing checks are unrelated and also happen on the main branch. could you advise on what's needed for merging this ? |
Member
|
/retest |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR exposes Envoy's Zipkin
trace_context_option(Envoy >= v1.36). It adds an optional field,EnvoyProxy.spec.telemetry.tracing.provider.zipkin.traceContextOption:UseB3(behaviour when unset): B3 headers only. This is how it works today.UseB3WithW3CPropagation: reads the trace context from B3 headers and falls back to the W3Ctraceparentheader when B3 is missing. Sends both B3 andtraceparentto upstreams.Why: meshes such as Istio use the Zipkin tracer, which uses B3 headers. Browsers (e.g. Grafana Faro), OpenTelemetry SDKs and many frameworks use W3C Trace Context by default. Switching the gateway to the OpenTelemetry tracer doesn't help, because Envoy's OpenTelemetry tracer only handles W3C and would break B3 trace continuity into the mesh. Today, dual propagation can only be enabled with an EnvoyPatchPolicy on the listener's tracing config.
Changes:
ZipkinTracingProvider.TraceContextOption(*ZipkinTraceContextOption, valuesUseB3/UseB3WithW3CPropagation, mirroring Envoy's names). There is no CRD default, so existing resources are unchanged.ZipkinConfig.TraceContextOption. When unset orUseB3, it resolves toUSE_B3, Envoy's default. Generated xDS for existing configs doesn't change, so existing EnvoyPatchPolicies and extension servers are unaffected.tracing-zipkinxDS translator testdata now covers the new option.Example:
Which issue(s) this PR fixes:
Fixes #10112
PR Checklist
git commit -s). See DCO: Sign your work./api), the API was discussed and agreed before the implementation. The API change can be in a separate PR, or in the same PR, but the API must be agreed before implementation. N/A if this PR does not contain API changes. API proposed in Expose Zipkin trace_context_option (B3 + W3C traceparent propagation) #10112.make generate gen-check,make lint, and the unit-test/coverage build pass. (Flaky e2e failures are not considered breakages, butgen-check,lint, and coverage MUST pass.) Locally,make gen-checkshows no diff for this change andmake lintpasses, exceptlint.kube-api-linter, which can't load its plugin on macOS; none of its enabled rules apply here.TestTranslateXds/merge-backends-consistent-hashalready fails on currentmain.tracing-zipkin) updated.site/content/en/latest/api/extension_types.md).release-notes/current/<section>/<pr-number>-<slug>.md(seerelease-notes/current/README.mdfor sections and naming). N/A if this PR does not contain non-trivial changes.new_features/10112-zipkin-trace-context-option.md.make gen-checkand committed the result if API/helm charts/modules changed.make gen-checkshows no diff for this change.release-notes/current/breaking_changes/. Optional field, no default, no xDS change when unset.