Skip to content

feat: include per-descriptor code and limitName in response dynamic metadata - #1239

Open
sc0ttbeardsley wants to merge 1 commit into
envoyproxy:mainfrom
sc0ttbeardsley:feat/response-dynamic-metadata-outcome
Open

feat: include per-descriptor code and limitName in response dynamic metadata#1239
sc0ttbeardsley wants to merge 1 commit into
envoyproxy:mainfrom
sc0ttbeardsley:feat/response-dynamic-metadata-outcome

Conversation

@sc0ttbeardsley

Copy link
Copy Markdown

Changes to dynamic metadata (RESPONSE_DYNAMIC_METADATA):

  • Only built when at least one descriptor is over its limit (breaking change)
  • Each descriptor now includes code (OK or OVER_LIMIT) from response status
  • Each descriptor now includes limitName (matched limit name, if configured)

Before:

  {descriptors: [{entries: [key=val]}], domain: ...}

After (only when over limit):

  {descriptors: [{entries: [key=val], code: OVER_LIMIT, limitName: my-rule}], ...}

…etadata

Changes to dynamic metadata (RESPONSE_DYNAMIC_METADATA):
- Only built when at least one descriptor is over its limit (breaking change)
- Each descriptor now includes code (OK or OVER_LIMIT) from response status
- Each descriptor now includes limitName (matched limit name, if configured)

Before:
  {descriptors: [{entries: [key=val]}], domain: ...}

After (only when over limit):
  {descriptors: [{entries: [key=val], code: OVER_LIMIT, limitName: my-rule}], ...}

Signed-off-by: Scott Beardsley <sbeardsley@pinterest.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant