Closed
envoy.code.check: remove stale entries_layout access in changelog date validation#5223
entries_layout access in changelog date validation#5223Conversation
✅ Deploy Preview for nifty-bassi-e26446 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix AttributeError in AChangelogStatus.check_date due to removed entries_layout
envoy.code.check: remove stale Sep 11, 2026
entries_layout access in changelog date validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
envoy.base.utilsremovedAChangelogs.entries_layout, butenvoy.code.checkstill referenced it inAChangelogStatus.check_date, causing anAttributeErrorat runtime when checking current changelogs. This PR alignsenvoy.code.checkwith the one-layout model and hardens the test that previously masked the stale lookup.Date-check logic update (
AChangelogStatus.check_date)project.changelogs.entries_layoutfrom the current-changelog guard.Test hardening (
test_abstract_changelog.py)test_changelogstatus_check_date_currentby patchingAChangelogStatus.projectviaPropertyMockand asserting it is not accessed, so staleproject.changelogs.*lookups cannot pass via truthyMagicMockchains.projectmocking fromtest_changelogstatus_check_date.entries_layoutcleanup scopeentries_layoutusage underpy/envoy.code.check(source/tests), keeping changes limited to this fix path only.