Draft
Re-enable current changelog entry-file validation by fixing entry_dir resolution#5225
Conversation
✅ Deploy Preview for nifty-bassi-e26446 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix entry directory computation for current changelog
Re-enable current changelog entry-file validation by fixing entry_dir resolution
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AChangelogStatus.entry_dirresolved current entries tochangelogs/<version>(derived from<version>.yaml), socheck_entry_filesexited early and never ran filename/content validation for current changelogs. This change points entry discovery atchangelogs/currentand turns a missing current entries directory into an explicit error instead of a silent no-op.Entry directory resolution (current changelog)
AChangelogStatus.entry_dirnow returnsself.project.changelogs.current_dir_pathwhenis_current, elseNone.changelog_path(version).with_suffix("").Missing-directory behavior
check_entry_filesnow distinguishes:entry_dir is None(non-current): return()entry_dirmissing: return"{version}: Missing changelog entries directory ({entry_dir})"entry_direxists but no*/*.rstentries: return()Test updates
test_changelogstatus_entry_dirto assertcurrent_dir_pathis used andchangelog_path/with_suffix/versionare not used in current mode.test_changelogstatus_check_entry_filesto cover missing-directory error and empty-directory no-op.current/<section>/<area>__<slug>.rstsurfaces viaAChangelogStatus.errorsasInvalid area.This re-enables validation that had been silently skipped; downstream consumers (notably Envoy) may surface pre-existing
Invalid area/ filename errors once this version is adopted.