Reduce Sentry noise from splat route scanner POSTs#3
Closed
kentcdodds wants to merge 3 commits into
Closed
Conversation
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@epic-web/workshop-appso the bundledroutes/$splat route has an action and is marked as action-capable in the server manifest.//,///), covering the Sentry example without affecting normal pages or action routes.Sentry
POST *splattohttps://object-oriented-typescript.epicweb.dev//You made a POST request to a catch-all route without an action for route "routes/$".Validation
npm run test:patch-workshop-apppassesnpm run typecheckpassesnpm run lintpasses with existing import-order warnings inextra/02.inventory-managerPOST //,POST ///,POST /wp-login.php, andPOST /does-not-existall return normal404 Not FoundPOST /login,POST /resources/lookout) still reach route actions and return400 Bad Requestfor missing/invalid payloadsnpm run validate:allis currently blocked before running by the existing missing rootnpm-run-allbinary (sh: 1: npm-run-all: not found).