Skip to content

Migrate API keys to the new Secret Storage API - #410

Open
vibbix wants to merge 8 commits into
esm7:masterfrom
vibbix:feature/add_proper_secret_handling
Open

vibbix wants to merge 8 commits into
esm7:masterfrom
vibbix:feature/add_proper_secret_handling

Conversation

@vibbix

@vibbix vibbix commented Aug 16, 2026

Copy link
Copy Markdown

Background

Currently, the API keys are just stored in the app settings. This isn't recommended anymore,

Changes

  • migrated all legacy keys to the new system
  • all places where keys got retrieved now use secretStorage

Testing

Validated locally end-to-end

Disclosure

No LLM's were used to write any code as part of this ticket.

@esm7

esm7 commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Thank you, at first glance it looks great! I'm currently traveling and have very little computer time, but in a couple of weeks I'll invest time on Map View updates, and will give this a proper review & merge :)

@vibbix

vibbix commented Sep 27, 2026

Copy link
Copy Markdown
Author

Just checking in, did you have a chance to look over this? I have a follow-up as well to enable additional routing via OpenRailwayMap as well, that depended on this that I wanted to add.

@esm7

esm7 commented Sep 29, 2026

Copy link
Copy Markdown
Owner

Hi, unfortunately I didn't yet have that time I thought I'll have to invest on Map View updates, including this :(
I was not aware of OpenRailwayMap and it looks amazing, an extremely worthy addition to Map View. It would be best if you create a branch on top of this one, and when the time finally comes, we can integrate both.
Sorry for the trouble, wish I could get to it faster!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants