You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you, at first glance it looks great! I'm currently traveling and have very little computer time, but in a couple of weeks I'll invest time on Map View updates, and will give this a proper review & merge :)
Just checking in, did you have a chance to look over this? I have a follow-up as well to enable additional routing via OpenRailwayMap as well, that depended on this that I wanted to add.
Hi, unfortunately I didn't yet have that time I thought I'll have to invest on Map View updates, including this :(
I was not aware of OpenRailwayMap and it looks amazing, an extremely worthy addition to Map View. It would be best if you create a branch on top of this one, and when the time finally comes, we can integrate both.
Sorry for the trouble, wish I could get to it faster!
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Currently, the API keys are just stored in the app settings. This isn't recommended anymore,
Changes
secretStorageTesting
Validated locally end-to-end
Disclosure
No LLM's were used to write any code as part of this ticket.