Skip to content

feat: update lsp4e dependency - #1500

Open
sigmaaa wants to merge 1 commit into
masterfrom
feat_update_lsp4e
Open

feat: update lsp4e dependency#1500
sigmaaa wants to merge 1 commit into
masterfrom
feat_update_lsp4e

Conversation

@sigmaaa

@sigmaaa sigmaaa commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Description

Bump the target-platform LSP4E p2 repo from 0.30.5 to 0.30.8.

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • Reloaded target platform; Tycho resolves org.eclipse.lsp4e / lsp4j from 0.30.8
  • SWTBot: IDFProjectLspCdtFunctionalityTest, NewEspressifIDFProjectClangFilesTest
  • Manual: new IDF project → build → open main.c — clangd start, content assist, hover, diagnostics, format, inlay hints, outline, signature help
  • After build / switching build dir, reopen a .c file: --compile-commands-dir= still applied and clangd restarts

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • org.eclipse.lsp4e / org.eclipse.lsp4e.debug / org.eclipse.lsp4j*
  • CDT-LSP / clangd C/C++ editor (com.espressif.idf.lsp, LspService)

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Chores
    • Updated the LSP4E repository source to release 0.30.8.

@sigmaaa sigmaaa self-assigned this Aug 21, 2026
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 587247f9-0c7b-4341-baf4-28bf16a4b4a0

📥 Commits

Reviewing files that changed from the base of the PR and between 944339b and d720b9f.

📒 Files selected for processing (1)
  • releng/com.espressif.idf.target/com.espressif.idf.target.target

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The target definition updates the LSP4E p2 repository URL from release 0.30.5 to 0.30.8.

Changes

LSP4E repository update

Layer / File(s) Summary
Update LSP4E repository location
releng/com.espressif.idf.target/com.espressif.idf.target.target
The target definition now references the LSP4E 0.30.8 repository.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to d720b

This localized dependency update is supported by target-platform resolution checks and clangd workflow testing; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: kolipakakondal, andriifilippov

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: updating the LSP4E dependency.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat_update_lsp4e

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant