Skip to content

ENG-1715: Sign generated-list commits - #11

Merged
JonathanGawrych merged 1 commit into
mainfrom
jag/eng-1715-sign-list-commits
Sep 18, 2026
Merged

JonathanGawrych merged 1 commit into
mainfrom
jag/eng-1715-sign-list-commits

Conversation

@JonathanGawrych

@JonathanGawrych JonathanGawrych commented Sep 18, 2026 •

Copy link
Copy Markdown

Automated list updates now create GitHub-signed commits with commit-headless using a CI App, so they can satisfy required commit signing and the App can bypass the main branch's pull-request requirement. Correct the branch-protection restore step to target etherfuse/tokenAssets.

Validation: actionlint reports only the existing checkout/setup-node runtime warnings; git diff --check passes. List generation, IPFS publishing, and branch-protection changes were not executed locally.

Configuration complete: the Tag and Release environment is restricted to main and contains RELEASE_APP_CLIENT_ID and RELEASE_APP_PRIVATE_KEY for etherfuse-ci-bot. Verified the private key authenticates as that App, its repository access includes Contents: write, and its pull-request ruleset bypass is configured. The existing ACCESS_TOKEN remains in use for the branch-protection steps.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@JonathanGawrych
JonathanGawrych force-pushed the jag/eng-1715-sign-list-commits branch from 5c89bbd to b328746 Compare September 18, 2026 18:32

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b328746. Configure here.

Comment thread .github/workflows/build.yml

@jordantgates jordantgates left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed tracked-file staging, the signed commit action, the existing bot-message loop guard, and the correction of the protection-restore repository owner. Validation CI and YAML/shell syntax checks pass. Code approved with the documented setup prerequisite: the CI App needs its own branch-rule bypass; toggling enforce_admins does not provide that. Confirm the release credentials and App access before merging. List generation, IPFS publication, and protection changes were not executed.

@JonathanGawrych
JonathanGawrych merged commit aca0b3c into main Sep 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants