Skip to content

Error: unterminated string #10

Description

@DonKracho

First of all, thanks for sharing your great work.

I use the polarshield server comiled for an Arduino Mega/Ramps 1.4 configuration (with A4988 drivers installed for Y and E1)

The polargraph cotroller struggled with garbage on the COM Port. There is a bug in comms.ino in the function void comms_extractParams(char* inS). When allocating space for the string on stack there has to be room for the trailing 0 character at the end of a C-string. (strlen() does not count this).

Therefore the first line (line:191) of the function should read as char in[strlen(inS) + 1];
The subsequent strcpy(in, inS) takes care about the trailing 0 of a C-string. so that's OK then.

Just another hint: My A4988 drivers did not get enabled. In configuration.ino I had to set the last parameter of setPinsInverted(false, false, true) to false, because the signal isn't inverted.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions