Skip to content

Handle receiving HTTP error codes (non-200) when downloading files. #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IsaacG merged 3 commits into from
Aug 22, 2026
Merged

Handle receiving HTTP error codes (non-200) when downloading files. #1246

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fce1b6d
Handle receiving HTTP error codes (non-200) when downloading files.
IsaacG Aug 21, 2026
f060de3
Increment success count after writing file
IsaacG Aug 21, 2026
5f5d7b0
Add trailing newline to print
IsaacG Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cmd/download.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ func runDownload(cfg config.Config, flags *pflag.FlagSet, args []string) error {
return err
}

var successes int
for _, sf := range download.payload.files() {
url, err := sf.url()
if err != nil {
Expand All @@ -98,8 +99,10 @@ func runDownload(cfg config.Config, flags *pflag.FlagSet, args []string) error {
defer res.Body.Close()

if res.StatusCode != http.StatusOK {
// TODO: deal with it
continue
if successes > 0 {
Comment thread
glennj marked this conversation as resolved.
fmt.Fprintf(Err, "Downloaded %d/%d files\n", successes, len(download.payload.files()))
}
return fmt.Errorf("received HTTP/%d when fetching %#v", res.StatusCode, url)
}

path := sf.relativePath()
Expand All @@ -117,6 +120,7 @@ func runDownload(cfg config.Config, flags *pflag.FlagSet, args []string) error {
if err != nil {
return err
}
successes++
}
fmt.Fprintf(Err, "\nDownloaded to\n")
fmt.Fprintf(Out, "%s\n", metadata.Dir)
Expand Down