Fixes: typos - missing use statement | harmonisation | cleaning up

[resu-xuniL]

• Fixed a typo in BookStoreTest.php
• Fixed a missing use statement in word_countTest.php
• Harmonise the order of the use statements
• Removed useless comments on MarkdownTest.php and its example.php

[no important files changed]

Tell me if i shall drop one or more, or all of these!

[github-actions]

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

[mk-mxp]

Thank you for scanning through the exercises and seeing these. I suggest using a PHPCS rule to ensure the order of use statements. We already have Slevomat rules at hand, so adding SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses is easy. In phpcs.xml, after the last rule add:

  <rule ref="SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses" />

and let vendor/bin/phpcbf auto-fix the order.

[mk-mxp]

By the way: Would you be interested in contributing more challenging stuff?

• Mentoring of students is a challenge on its own. Exercism always needs people helping with mentoring...
• The PHP track has a lot of concepts without exercises, for example. These concepts are not accessible for students. Adding exercises makes them part of the syllabus (learning path) - great student experience enhancement. We do not yet have a mermaid roadmap or overview like this of these, so this might be a challenge before converting exercises from other tracks for the concepts, too. I made a small one of the existing concept exercises in the past.
• There is a need for an analyzer, a very advanced tool to automate mentoring feedback running after submission of the solved exercises (you may have seen it on other tracks). But that really is an advanced topic consuming a lot of energy / time.

[resu-xuniL]

I'll check, but not quite sure I'll be experimentd enough to manage one of these challenges!

[mk-mxp]

and let vendor/bin/phpcbf auto-fix the order.

Looks like this turned everything around again. That's OK, same order in all exercises. I think tournament (was merged last) still needs fixing 😄

[resu-xuniL]

yes Tournament is my problem now ^^

[resu-xuniL]

I do not understand the fail : Running tests for: tournament PHP Fatal error: Cannot use PHPUnit\Framework\Attributes\TestDox as TestDox because the name is already in use in /tmp/tournament.nFUSP2P7us/TournamentTest.php on line 7

Is it merging the 2 files and keping the line 7 where was the use?

[mk-mxp]

I think the + in your branch name kills GitHub. I cannot open the exercise folder: https://github.com/resu-xuniL/exercism_php/tree/typos%2Bmissing-use/exercises fails. Rename the branch and open a new Pull Request.

[mk-mxp]

If you are interested in more "plumbing" challenges:

• We should update the track to support PHP 8.3 - 8.5 officially. That's tooling, documentation and some cross-repo coordination to do (this repo, test runner and representer must be in sync)
• We still are not making progress with the test generator. We have a basic one for new exercises, but synchronisation is hand-made. Other tracks have template-based generators for re-producing the tests files when canonical data changes / is extended. We had some tries on that, but ran out of time / energy to make them happen