Update vendored cloudpickle tests to v3.1.2 - #126
Merged
Merged
Conversation
The vendored cloudpickle was updated to 3.1.2 in a10431b, but its tests were still the v2.2.0 copies, which import the removed srsly.cloudpickle.compat module and fail to collect. Re-vendor the tests from upstream v3.1.2 (same file set as before), rewriting imports to srsly.cloudpickle and srsly.tests.cloudpickle.testutils. Local adaptations, both for how srsly's CI runs pytest: - Skip the two stdout/stderr pickling tests, which need `pytest -s` (upstream sets addopts = -s). - Ignore the itertools pickling DeprecationWarning in test_itertools_count, since CI runs with -Werror. Closes #121. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
It isn't a package, so find_packages skips it, and the cloudpickle by-value pickling test fails when srsly is installed from the sdist, as CI does. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Upstream notes the 50MB growth bound is only tight on macOS (~1MB on Linux). Locally it exceeded the bound in 4 of 12 runs. It still runs on Linux and Windows. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Sep 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored cloudpickle was updated to 3.1.2 in a10431b, but its tests were still the v2.2.0 copies. They import the removed
srsly.cloudpickle.compatmodule and fail to collect, so CI onv2.xis currently red on every Python version.srsly.cloudpickleandsrsly.tests.cloudpickle.testutils.pytest -s(upstream setsaddopts = -s)DeprecationWarningintest_itertools_count, since CI runs with-Werrormock_local_folderfixture in the sdist. It isn't a package, sofind_packagesskipped it and a test failed when installed from the sdist, as CI does.Tested with the CI flow (sdist install,
pytest --pyargs srsly -Werror) on Python 3.9–3.14, three runs each, together with the other pending v2.x fixes.Closes #121.
🤖 Generated with Claude Code