Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Improves
UndefinedAttributemessages for callable attributes on templatedStrictMockobjects. Synchronous callables now point totestslide.mock_callable(), while coroutine functions point totestslide.mock_async_callable().Fixes #128
Why:
The existing message only says that the attribute must be set. For template methods, that misses TestSlide's dedicated callable-mocking APIs, which provide call validation and expectations.
How:
StrictMock.__getattr__inspects the matching template attribute and appends a targeted tip. The tests cover synchronous and asynchronous instance, static, and class methods while preserving the existing message for non-callable attributes.Risks:
Low. The exception type and existing message prefix are unchanged. Only callable attributes receive one additional guidance line.
Test results:
main.git diff --checkpasses.Testing limitation:
The complete StrictMock test file cannot pass locally on Python 3.13 because the existing subclass setup rejects Python 3.13's
__firstlineno__attribute as unsupported. This failure occurs on untouchedmainand is unrelated to this change. The repository CI uses Python 3.10.Checklist: