Skip to content

Restore falsy attribute values on unpatch #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kwy404 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Restore falsy attribute values on unpatch #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/patch_attribute_testslide.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,3 +217,9 @@ def patch_attribute_passes_for_private_with_allow_private(self):
self.patch_attribute(
sample_module.SomeClass, "_private_attr", "notsoprivate", allow_private=True
)

@context.example
def unpatching_restores_falsy_values(self):
self.patch_attribute(sample_module.SomeUnhashableClass, "class_attr", 1)
unpatch_all_mocked_attributes()
self.assertEqual(sample_module.SomeUnhashableClass.class_attr, 0)
4 changes: 2 additions & 2 deletions testslide/core/patch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def _patch(
setattr(type(target), attribute, property(fget=lambda _: new_value))

def unpatcher() -> None:
if restore_value:
if restore or restore_value:
setattr(type(target), attribute, original_property)
else:
delattr(target, attribute)
Expand All @@ -105,7 +105,7 @@ def unpatcher() -> None:
setattr(target, attribute, new_value)

def unpatcher() -> None:
if restore_value:
if restore or restore_value:
setattr(target, attribute, restore_value)

else:
Expand Down