Update mdl, mocha and rake dependencies.#1
Closed
faisal wants to merge 5 commits into
Closed
Conversation
Aruba is a recurring source of dependency conflicts when updating Rubycritic dependencies*. Update Aruba call sites to call the underlying command line calls directly. Call with Open3 so as to capture results and return status. * Most recently, being able to update to diff-lcs 2.0, which we do in this commit. We ran into it more before when Rubycritic relied on Cucumber, though it doesn't any more.
faisal
force-pushed
the
update_mocha_and_rake
branch
from
8097338 to
f730cae
Compare
faisal
changed the title
Co-authored-by: Juan Vásquez <javasgon@gmail.com>
…h#572) - Add lang="en" on <html> so screen readers and translation features pick the correct language for the entire report. - Give the navbar menu-toggle anchor an accessible name via aria-label. - Make per-rating summary IDs unique (rating-<a-f>-{files,churns,smells}) so the HTML spec's unique-ID requirement holds and JS/test selectors can target individual cells. Verified via pa11y --standard WCAG2AA on overview.html: before 50 errors after 34 errors (-16: -15 dup IDs, -1 missing lang, +1 anchor label) Remaining 34 (deliberately out of scope for this PR): - 30 G18 + 3 G145 contrast violations on #A4A4A4 grays — opinionated style change, would prefer maintainer-led decision before changing. - 1 F77 duplicate id="page-content-wrapper" — cross-page (affects overview/smells_index/simple_cov_index templates), separate scope. Tests + RuboCop green. Test snapshot under test/samples/ auto-updated to reflect the new template output.
# Conflicts: # CHANGELOG.md
faisal
force-pushed
the
update_mocha_and_rake
branch
from
f730cae to
1c31442
Compare
faisal
force-pushed
the
replace_aruba
branch
2 times, most recently
from
4d819c6 to
a7e11c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this stacks on the Aruba removal in whitesmith#571
Check list: