Remove temp file when file is successfully uploaded - #167
Closed
aaronofinn wants to merge 1 commit into
Closed
aaronofinn wants to merge 1 commit into
aaronofinn wants to merge 1 commit into
Conversation
|
Member
|
I think we should remove this feature of file upload, I tried to do this to illustrate the use of the multipart plugin and streams usage, but there are several system design flaws that fixing theme would make to much noise for a basic demo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



When uploading a file for a task that already has a file, it moves the old file to a temp directory. But on a successful upload, the temporary file still stays there so this is just a small fix to remove that temp file when the operation is successful.
How to reproduce (before this fix)
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct