Enhance DCA processing for REQUEST_PATH in nested fragments - #61
Open
vagetman wants to merge 1 commit into
Open
Conversation
…_STRING` in nested fragments Fixes #49
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Aligns nested dca=esi fragment processing with Akamai behavior by ensuring request-scoped variables reflect the fragment URL instead of the top-level client request.
Changes:
- Pass the fragment request into isolated processors so
REQUEST_PATH/QUERY_STRINGare derived from the fragment context in nested DCA scenarios. - Add regression tests covering nested
dca=esibehavior forREQUEST_PATHandQUERY_STRING, plus a top-level guard test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| esi/src/lib.rs | Uses the fragment request (instead of the parent request) when spawning isolated processors for nested DCA/ESI evaluation. |
| esi/tests/dca_tests.rs | Adds run_with_request helper and new tests validating REQUEST_PATH/QUERY_STRING semantics in nested fragments. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjustments ensure that
REQUEST_PATHreflects the fragment's URL in nested ESI scenarios, aligning with Akamai's behavior. Additionally,QUERY_STRINGnow accurately represents the fragment's query string.Fixes #49