Skip to content

Enhance DCA processing for REQUEST_PATH in nested fragments - #61

Open
vagetman wants to merge 1 commit into
mainfrom
vadim/request_path
Open

Enhance DCA processing for REQUEST_PATH in nested fragments#61
vagetman wants to merge 1 commit into
mainfrom
vadim/request_path

Conversation

@vagetman

Copy link
Copy Markdown
Collaborator

Adjustments ensure that REQUEST_PATH reflects the fragment's URL in nested ESI scenarios, aligning with Akamai's behavior. Additionally, QUERY_STRING now accurately represents the fragment's query string.

Fixes #49

@vagetman
vagetman marked this pull request as ready for review August 25, 2026 14:55
@vagetman
vagetman requested a lite review from Copilot September 1, 2026 15:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Aligns nested dca=esi fragment processing with Akamai behavior by ensuring request-scoped variables reflect the fragment URL instead of the top-level client request.

Changes:

  • Pass the fragment request into isolated processors so REQUEST_PATH/QUERY_STRING are derived from the fragment context in nested DCA scenarios.
  • Add regression tests covering nested dca=esi behavior for REQUEST_PATH and QUERY_STRING, plus a top-level guard test.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
esi/src/lib.rs Uses the fragment request (instead of the parent request) when spawning isolated processors for nested DCA/ESI evaluation.
esi/tests/dca_tests.rs Adds run_with_request helper and new tests validating REQUEST_PATH/QUERY_STRING semantics in nested fragments.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

$(REQUEST_PATH) represents top level path in nested ESI scenarios

3 participants