Repository navigation
Conversation
zkat
requested changes
Oct 9, 2026
zkat
left a comment
Member
There was a problem hiding this comment.
this is the wrong target branch. We'll need to create a separate release branch that forks off pre-3.x and apply this there instead. I can take care of that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
@bytecodealliance/wevaldependency to 0.5.0 and the@bytecodealliance/jcodependency to1.17.9. The fixnpm auditsuggests is a downgrade to 3.22.4 (from before weval was added), so users have no good way to clear the finding on their side.This is a backport of #1601 to v3.
Unlike v4, this branch actually linked to
@bytecodealliance/jco@1.7.0. I've bumped to@bytecodealliance/jco@1.17.9, the same version used by v4, and verified that built binaries are identical before and after this bump.Impact
decompressis only used by weval'sgetWeval(). That runs when the CLI first does an AOT compilation, which is now the default in 4.0.0. It unpacks the weval binary downloaded from the bytecodealliance/weval GitHub releases intonode_modules. It runs on the developer's machine or in CI, not inside the Compute sandbox. Exploiting the advisory would need a malicious archive to be served at that download URL, so the practical risk is low. The audit finding is still critical, and it affects every downstream project.