Skip to content

Fix: Fixed issue where password popup was displayed multiple times when copying from an encrypted archive - #18772

Open
yair100 wants to merge 1 commit into
mainfrom
ya/Password
Open

Fix: Fixed issue where password popup was displayed multiple times when copying from an encrypted archive#18772
yair100 wants to merge 1 commit into
mainfrom
ya/Password

Conversation

@yair100

@yair100 yair100 commented Jul 27, 2026

Copy link
Copy Markdown
Member

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Confirmed password prompt was only displayed once

@yair100
yair100 requested a review from Josh65-2201 July 27, 2026 22:06
@yair100 yair100 added the ready for review Pull requests that are ready for review label Jul 27, 2026
@Josh65-2201

Josh65-2201 commented Jul 27, 2026

Copy link
Copy Markdown
Member

This also keeps it unlock after opening and then backing out (No operation was done)

Trying to extract (7z encrypted from Files), It gives a file not found prompt. This is also happening in 4.2.1 on the same Windows install so I can not test further

@Josh65-2201

Copy link
Copy Markdown
Member

This also keeps it unlock after opening and then backing out (No operation was done)

This isn't happening anymore.

Trying to extract (7z encrypted from Files), It gives a file not found prompt. This is also happening in 4.2.1 on the same Windows install so I can not test further

This still is with a new Windows VM.

@yair100

yair100 commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Do you have a different file to test with? This is working properly on my side.

@Josh65-2201

Copy link
Copy Markdown
Member

I have made multiple 7z using Files to test with. I haven't tested the one provided in the issue, I will try that

@Josh65-2201

Josh65-2201 commented Aug 4, 2026

Copy link
Copy Markdown
Member

With the issue provide zip it works as expected, although used what looked like a Windows version of the password prompt and not Files design. It's now always unlocked and can be moved even after replacing the zip with a new copy so I can't get a screenshot of the dialog it showed. Got it to show
image

Holding Ctrl to copy instead of moving crashes it. This also happens when opening a encrypted 7z archive.
debug.log

@Josh65-2201 Josh65-2201 added changes requested Changes are needed for this pull request and removed ready for review Pull requests that are ready for review labels Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes requested Changes are needed for this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Files repeatly asks for password when copying a folder from an encrypted archive

2 participants