Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for Cloud Run configurations by defining the RunSingle schema and TypeScript interface, and integrating the run property into the Firebase configuration. It also includes a unit test to validate a correct run configuration. The review feedback recommends adding a test case for an invalid configuration (such as one missing the required serviceId) to align with the repository's style guide of testing edge cases and error conditions.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for Cloud Run configuration (under the run field) in the Firebase configuration schema and TypeScript types. It defines the RunSingle schema and interface with properties such as serviceId, region, rootDir, ignore, serviceAccount, and localBuild, and updates the validation tests to verify correct parsing, required fields, and type constraints. There are no review comments, and I have no feedback to provide.
Description
Scenarios Tested
Sample Commands