Skip to content

Create a basic, initial schema for firebase.json - #11183

Open
falahat wants to merge 3 commits into
mainfrom
bapi_firebase_json
Open

falahat wants to merge 3 commits into
mainfrom
bapi_firebase_json

Conversation

@falahat

@falahat falahat commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Description

Scenarios Tested

Sample Commands

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Cloud Run configurations by defining the RunSingle schema and TypeScript interface, and integrating the run property into the Firebase configuration. It also includes a unit test to validate a correct run configuration. The review feedback recommends adding a test case for an invalid configuration (such as one missing the required serviceId) to align with the repository's style guide of testing edge cases and error conditions.

Comment thread src/firebaseConfigValidate.spec.ts
@falahat

falahat commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Cloud Run configuration (under the run field) in the Firebase configuration schema and TypeScript types. It defines the RunSingle schema and interface with properties such as serviceId, region, rootDir, ignore, serviceAccount, and localBuild, and updates the validation tests to verify correct parsing, required fields, and type constraints. There are no review comments, and I have no feedback to provide.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants