FormProduct assembly into LRC matrix#5192
Draft
pbrubeck wants to merge 7 commits into
Draft
Conversation
pbrubeck
force-pushed
the
pbrubeck/form-product
branch
from
June 18, 2026 21:13
5a1f94f to
c364547
Compare
pbrubeck
force-pushed
the
pbrubeck/form-product
branch
3 times, most recently
from
June 19, 2026 22:17
f076b8b to
e0b6ca7
Compare
pbrubeck
force-pushed
the
pbrubeck/form-product
branch
from
June 24, 2026 20:19
e0b6ca7 to
13c5a92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disclamer: generated with Codex CLI
Assemble a
ufl.FormProductinto a low-rank matrixu v^Tin LRC (low rank correction) format.Depends on FEniCS/ufl#490
I think this matrix format might be the key to properly deal with dense rows in PETSc, in a MUMPS-friendly way.
TODO:
FormProductbetween more than 2 factors (0-Forms included) of total rank <= 2.FormProductandFormSum,Action,AdjointFormProduct, so that they can benefit from LRC assembly (eitheruorv^Tbecomes a vector of length 1)