Fix Dockerfile hadolint violations - #95
Merged
Merged
Conversation
Co-authored-by: firefart <105281+firefart@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job hadolint
Fix Dockerfile hadolint violations
Aug 24, 2026
firefart
marked this pull request as ready for review
August 24, 2026 21:25
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped to lint compliance and preserve the existing runtime behavior.
Pull request overview
This PR updates the Docker image build to satisfy hadolint requirements by switching USER directives to numeric UIDs and converting the healthcheck to JSON (exec) form while preserving the existing shell-based behavior.
Changes:
- Replace
USER rt/USER rootwithUSER 1000/USER 0. - Convert the Docker
HEALTHCHECKto exec-form (CMD [...]) usingsh -cto retain env-assignment semantics.
File summaries
| File | Description |
|---|---|
| Dockerfile | Updates USER directives to numeric UIDs and rewrites the healthcheck into JSON exec-form to address hadolint violations. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| CMD [ "/usr/bin/spawn-fcgi", "-d", "/opt/rt/", "-p" ,"9000", "-a","0.0.0.0", "-u", "1000", "-n", "--", "/opt/rt/sbin/rt-server.fcgi" ] | ||
|
|
||
| HEALTHCHECK --interval=10s --timeout=3s --start-period=10s --retries=3 CMD REQUEST_METHOD=GET REQUEST_URI=/ SCRIPT_NAME=/ cgi-fcgi -connect localhost:9000 -bind || exit 1 | ||
| HEALTHCHECK --interval=10s --timeout=3s --start-period=10s --retries=3 CMD [ "sh", "-c", "REQUEST_METHOD=GET REQUEST_URI=/ SCRIPT_NAME=/ cgi-fcgi -connect localhost:9000 -bind || exit 1" ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
hadolintActions job failed on namedUSERdirectives and shell-form healthcheck syntax.User directives
Healthcheck