feat: refine and animate the autosaving note modal - #377
Merged
Merged
Conversation
Keep the writing surface dark and translucent without the reflective rim. Use a native close control and a bottom-right color swatch so the header and body have more room. Remove the modal export and Done actions and keep existing autosave, with autocorrection disabled for both inputs. Validation: regenerated projects; KeepMac, signed iPhone, and SE fixture builds passed. Verified native close, color popover, and autosave while open with the isolated fixture. Software-keyboard visual inspection is pending because Simulator hides it during automation. Model: GPT-6 Co-Authored-By: Codex <noreply@openai.com>
Bind the tapped card ID to the sheet destination so opening and closing use SwiftUI's native zoom transition. Keep card glass surfaces independent: the shared glass container yielded a nil source and a fallback animation. Reduce Motion, new notes, Spotlight, and older iOS keep standard sheets. Use a hollow circle for an unset color and an ASCII-capable keyboard to remove the empty prediction strip while preserving pasted Unicode text. Validation: Mac, signed iPhone, and SE fixture builds passed. Recorded card expansion and return; no nil-source fallback warnings. Verified software keyboard without the empty strip and autosave while open. Model: GPT-6 Co-Authored-By: Codex <noreply@openai.com>
fjbarrett
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tapping a note card now expands it into the editor and dismissal returns it to the card using SwiftUI's native zoom transition. Each card retains its Liquid Glass styling on an independent surface so the system can resolve the transition source. New notes, Spotlight, Reduce Motion, and older iOS use standard sheet presentation.
The editor has a native glass close button at the top-right and a color chooser at the bottom-right; no color appears as a hollow circle. Its rounded translucent surface has no reflective outline and keeps a dark charcoal tone in dark mode. The modal omits floppy export and Done buttons. Edits continue to autosave while typing, and an ASCII-capable keyboard with autocorrection disabled removes the empty suggestion strip. File export remains in the card context menu.
Test plan
Model: GPT-6
Co-Authored-By: Codex noreply@openai.com