fix: keep notes open on swipe and remove the modal rim - #379
Merged
Merged
Conversation
Require the existing close button to dismiss notes. Let the editor surface fill its presentation so the inset rim disappears, compensating internal padding to preserve text and control positions. Validation: KeepMac, signed iPhone, and SE simulator builds passed. Fast and slow downward gestures keep notes open, including new notes; close works. Light and dark surfaces verified. Model: GPT-6 Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Existing and new notes now stay open during swipe gestures and close using the existing × button. The editor surface fills its presentation to remove the inset rim; adjusted internal padding preserves text and control positions.
Test plan
Model: GPT-6
Co-Authored-By: Codex noreply@openai.com