fix: keep the opened note stationary during drags - #380
Merged
Conversation
Present the editor in a fixed cover to remove sheet movement while preserving the native card zoom and close control. Keep sign-in as a sheet and defer it until an open editor finishes closing after session expiry. Validation: KeepMac, signed iPhone, and SE simulator builds passed. Video confirms stationary title and controls through downward and edge drags, with body scrolling intact. New-note autosave and expired-session handoff to sign-in passed. Model: GPT-6 Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opened notes now stay stationary during drags. A fixed cover replaces the movable sheet while retaining the native card zoom, rounded editor, text insets, and × close button. Body text remains scrollable.
Sign-in keeps its sheet presentation and waits for an open editor to finish closing when authentication expires.
Test plan
Model: GPT-6
Co-Authored-By: Codex noreply@openai.com