fix: float note editor controls over scrolling text - #382
Merged
Merged
Conversation
Remove the full-width header and bottom strips so the note body scrolls behind the close and color controls. Fade the title as content moves upward and keep internal text insets so the first and final lines remain accessible. Use a native text view to retain real scrolling insets and offset callbacks while preserving reading preferences, focus handoff, and autosave. Verified iOS simulator and signed device builds, the Mac build gate, light/dark layouts, larger text, editing, color saves, and error recovery. The simulator software keyboard remained hidden during verification. Model: GPT-6 Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The opened note previously reserved full-width strips for its header and bottom color control. The close and color buttons now float over scrolling text on circular glass surfaces, and the title fades upward as the body scrolls, returning at the top.
A native text view keeps header spacing and bottom clearance inside the scrolling content. It preserves reading preferences, title-to-body focus, the suggestion-free keyboard, and autosave. Save-error recovery continues to reserve accessible space.
Test plan
Regenerated Xcode projects; Mac scheme, signed iOS device build, and SE simulator build pass.
Verified long-note scrolling, title disappearance/return, final-line clearance, and floating color popover.
Verified new-note title/body entry, Return focus handoff, autosave and color changes with a local API fixture.
Verified light/dark mode and accessibility text size.
Simulated save failure; recovery actions remained reachable, and pending changes saved after relaunch with a healthy fixture.
Software keyboard visual verification is limited: Simulator continued hiding it despite its hardware-keyboard preference being off.
Installed build 20260905.382 on the physical iPhone SE and verified its live process matches the installed app container.