Skip to content

fix(MESHAGEN-010-2): CU-86akbhhdk 2 review findings in release.yml #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
flamingo wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Draft

fix(MESHAGEN-010-2): CU-86akbhhdk 2 review findings in release.yml #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ jobs:
release:
name: "Create Release"
needs: [version, changes, build, build_helm]
if: ${{ !failure() && !cancelled() }}
if: ${{ github.event_name == 'workflow_dispatch' && !failure() && !cancelled() }}
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand Down Expand Up @@ -196,3 +196,4 @@ jobs:
prerelease: ${{ github.event_name == 'push' }}
token: ${{ secrets.GITHUB_TOKEN }}
body_path: RELEASE_HEADER.md

Comment on lines 196 to +199

@flamingo flamingo Bot Aug 24, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🔴 release.yml creates a GitHub Release automatically on push to master, not gated on workflow_dispatch

Added github.event_name == 'workflow_dispatch' && to the if: condition of the release job (line ~186), so the job (and its Create Release step using softprops/action-gh-release) will now only run when manually triggered via workflow_dispatch, not on push to master.

🤖 Prompt for AI agents 
In .github/workflows/release.yml around line 186, review and complete this code-review fix: release.yml creates a GitHub Release automatically on push to master, not gated on workflow_dispatch.
What the draft fix changed: Added `github.event_name == 'workflow_dispatch' &&` to the `if:` condition of the `release` job (line ~186), so the job (and its `Create Release` step using `softprops/action-gh-release`) will now only run when manually triggered via workflow_dispatch, not on push to master.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟢 90 high — react 👍/👎 to teach the reviewer

Comment on lines 196 to +199

@flamingo flamingo Bot Aug 24, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🔴 release job lacks workflow_dispatch-only gate, enabling automatic release publication on push

Same edit as finding 1 (the release job's gating condition at line ~208 covers the Create Release step) ensures softprops/action-gh-release cannot execute on push events. Left prerelease: ${{ github.event_name == 'push' }} unchanged since the job can no longer run on push, making that expression dead but harmless; a more thorough fix could simplify/remove it, but doing so risks altering intended prerelease semantics beyond the scope of this finding.

🤖 Prompt for AI agents 
In .github/workflows/release.yml around line 208, review and complete this code-review fix: release job lacks workflow_dispatch-only gate, enabling automatic release publication on push.
What the draft fix changed: Same edit as finding 1 (the `release` job's gating condition at line ~208 covers the `Create Release` step) ensures `softprops/action-gh-release` cannot execute on `push` events. Left `prerelease: ${{ github.event_name == 'push' }}` unchanged since the job can no longer run on push, making that expression dead but harmless; a more thorough fix could simplify/remove it, but doing so risks altering intended prerelease semantics beyond the scope of this finding.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟡 85 medium — react 👍/👎 to teach the reviewer